diff options
| author | Gareth Rees <gareth@mysociety.org> | 2014-08-28 15:43:46 +0100 | 
|---|---|---|
| committer | Gareth Rees <gareth@mysociety.org> | 2014-08-28 15:43:46 +0100 | 
| commit | d801fff4325a42f1bbbb273ac0a4597c32b4dd4b (patch) | |
| tree | 5b9d4828b2c6bf8415ccabb0140eb730ed12ceca /app/controllers/user_controller.rb | |
| parent | 0b511943ef5a8835af34842291725d1dce74b25a (diff) | |
| parent | 533f0ab5f402e110f42d50fb6906a6b58ae312f7 (diff) | |
Merge remote-tracking branch 'origin/release/0.19'0.19
Diffstat (limited to 'app/controllers/user_controller.rb')
| -rw-r--r-- | app/controllers/user_controller.rb | 12 | 
1 files changed, 6 insertions, 6 deletions
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index 8d6522923..fcc500e06 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -46,7 +46,7 @@ class UserController < ApplicationController          @is_you = !@user.nil? && @user.id == @display_user.id          # Use search query for this so can collapse and paginate easily -        # XXX really should just use SQL query here rather than Xapian. +        # TODO: really should just use SQL query here rather than Xapian.          if @show_requests              begin                  requests_query = 'requested_by:' + @display_user.url_name @@ -102,11 +102,11 @@ class UserController < ApplicationController          @is_you = !@user.nil? && @user.id == @display_user.id          feed_results = Set.new          # Use search query for this so can collapse and paginate easily -        # XXX really should just use SQL query here rather than Xapian. +        # TODO: really should just use SQL query here rather than Xapian.          begin              requests_query = 'requested_by:' + @display_user.url_name              comments_query = 'commented_by:' + @display_user.url_name -            # XXX combine these as OR query +            # TODO: combine these as OR query              @xapian_requests = perform_search([InfoRequestEvent], requests_query, 'newest', 'request_collapse')              @xapian_comments = perform_search([InfoRequestEvent], comments_query, 'newest', nil)          rescue @@ -121,7 +121,7 @@ class UserController < ApplicationController          if @is_you              @track_things = TrackThing.find(:all, :conditions => ["tracking_user_id = ? and track_medium = ?", @display_user.id, 'email_daily'], :order => 'created_at desc')              for track_thing in @track_things -                # XXX factor out of track_mailer.rb +                # TODO: factor out of track_mailer.rb                  xapian_object = ActsAsXapian::Search.new([InfoRequestEvent], track_thing.track_query,                      :sort_by_prefix => 'described_at',                      :sort_by_ascending => true, @@ -262,7 +262,7 @@ class UserController < ApplicationController          end      end -    # Change password (XXX and perhaps later email) - requires email authentication +    # Change password (TODO: and perhaps later email) - requires email authentication      def signchangepassword          if @user and ((not session[:user_circumstance]) or (session[:user_circumstance] != "change_password"))              # Not logged in via email, so send confirmation @@ -288,7 +288,7 @@ class UserController < ApplicationController                      :reason_params => {                          :web => "",                          :email => _("Then you can change your password on {{site_name}}",:site_name=>site_name), -                        :email_subject => _("Change your password {{site_name}}",:site_name=>site_name) +                        :email_subject => _("Change your password on {{site_name}}",:site_name=>site_name)                      },                      :circumstance => "change_password" # special login that lets you change your password                  )  | 
