Added charset checks on incoming msgs (from the IRC side) to prevent possible

crashes/other odd behaviour in IM modules (or a GLib function that crashes on
non-UTF-8 strings).

1 files changed, 14 insertions, 3 deletions

diff --git a/irc.c b/irc.c
index 5531addb..01d4c47e 100644
--- a/irc.c
+++ b/irc.c
@@ -319,11 +319,22 @@ void irc_process( irc_t *irc )
 				break;
 			}
 			
-			if( ( cs = set_getstr( &irc->set, "charset" ) ) && ( g_strcasecmp( cs, "utf-8" ) != 0 ) )
+			if( ( cs = set_getstr( &irc->set, "charset" ) ) )
 			{
 				conv[IRC_MAX_LINE] = 0;
-				if( do_iconv( cs, "UTF-8", lines[i], conv, 0, IRC_MAX_LINE - 2 ) != -1 )
-					lines[i] = conv;
+				if( do_iconv( cs, "UTF-8", lines[i], conv, 0, IRC_MAX_LINE - 2 ) == -1 )
+				{
+					if( irc->status & USTATUS_LOGGED_IN )
+						irc_usermsg( irc, "ERROR: Charset mismatch detected. The charset "
+						                  "setting is currently set to %s, so please make "
+						                  "sure your IRC client will send and accept text in "
+						                  "that charset, or tell BitlBee which charset to "
+						                  "expect by changing the charset setting. See "
+						                  "`help set charset' for more information. Your "
+						                  "message was ignored.", cs );
+					*conv = 0;
+				}
+				lines[i] = conv;
 			}
 			
 			if( ( cmd = irc_parse_line( lines[i] ) ) == NULL )